Add support for Filter query parameter to list images api #6878
Conversation
|
Hi @skorhone. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
skorhone
force-pushed
the
fix/docker_v1_24_image_list_compatibility
branch
from
ce18785 to
6c3f80a
Compare
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
pkg/api/handlers/utils/images.go
Outdated
| if len(query.Filters) > 0 { | ||
| for k, v := range query.Filters { | ||
| queryFilters := query.Filters | ||
| if len(query.Filter) > 0 { // Docker 1.24 compatibility |
There was a problem hiding this comment.
Here, we need to make sure that we only accept this parameter for the docker-compat endpoints. There's a helper function to check if the request for libpod:
if !IsLibpodRequest(r) && en(query.Filter) > 0 { ...
|
@vrothberg I'll have a look at those tests. Also, it seems that currently name/reference filter is a bit too relaxed. It does seem to allow partial matches for names and tags. If it's much of an issue with name, but tag matching should be strict. Filter for image:v1 should not match with image:v10 like it currently does. |
skorhone
force-pushed
the
fix/docker_v1_24_image_list_compatibility
branch
2 times, most recently
from
55dd925 to
b2e6fc9
Compare
Docker api version 1.24 uses a query parameter named Filter
for filtering images by names. In more recent versions of
api name filter is in filters query parameter with other
filters
This patch adds a mapping that translates Filter query
parameter to Filters={"reference": [""]}
Signed-off-by: Sami Korhonen <[email protected]>
skorhone
force-pushed
the
fix/docker_v1_24_image_list_compatibility
branch
from
b2e6fc9 to
610118d
Compare
|
@vrothberg Now there's both positive and negative test cases |
|
@baude @mheon @QiWang19 @ashley-cui PTAL |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, skorhone The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Docker api version 1.24 uses a query parameter named Filter for filtering images by names. In more recent versions of api name filter is in filters query parameter with other filters
This patch adds a mapping that translates Filter query parameter to Filters={"reference": [""]}
Patch resolves issue: #6797