Fix container inspect endpoint returning null for network settings / ports

[skorhone]

Fixes compatibility issue with testcontainers.

This pull requests adds list of ports to NetworkSettings.Ports

Docker inspect returns Ports:

        "NetworkSettings": {
            "Bridge": "",
            "SandboxID": "8481a8888bee4be0737c003ab80224e8bbcf22064e55a19e93a7eb33f253fd9c",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {
                "2222/tcp": [
                    {
                        "HostIp": "0.0.0.0",
                        "HostPort": "32770"
                    }
                ]
            },

After this change podman returns ports from compat API interface:

  "NetworkSettings": {
    "Bridge": "",
    "SandboxID": "",
    "HairpinMode": false,
    "LinkLocalIPv6Address": "",
    "LinkLocalIPv6PrefixLen": 0,
    "Ports": {
      "2222/tcp": [
        {
          "HostIp": "",
          "HostPort": "38947"
        }
      ]
    },

Incorrect HostIp is out of scope for this pull request. I think that mapping empty string to 0.0.0.0 should be done in libpod/container_inspect.go rather than doing it in api/compat/container.go. Considering that I don't fully understand side effects that change to container_inspect could have caused, I decided to not to implement it.

[openshift-ci-robot]

Hi @skorhone. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhatdan]

/ok-to-test

[rhatdan]

LGTM
@mheon @baude PTAL

[baude]

lgtm, @mheon ptal

[baude]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, skorhone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

/lgtm