In rootless + cgroupsv1, resource limits are an error #6837
Conversation
openshift-ci-robot
added
the
approved
However, in some cases (unset limits), we can completely remove the limit and avoid errors. This works around a bug where the Podman frontend is setting a Pids limit of 0 on some rootless systems. For now, this is only implemented for the PID limit. It can easily be extended to other resource limits, but it is a fair bit of code to do so, so I leave that exercise to someone else. Fixes containers#6834 Signed-off-by: Matthew Heon <[email protected]>
|
@goochjj This seems to work on my Debian Testing cgroupsv1 machine, but I'd appreciate it if you verify as well. |
|
@mheon YES THANK YOU |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think this should be handled via this PR. |
|
where are we with this one ? |
|
Dan's proposed alternative is more elegant, but also requires a revendor and is failing tests. |
|
@mheon: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
github-actions
bot
added
the
locked - please file new issue/PR
However, in some cases (unset limits), we can completely remove the limit and avoid errors. This works around a bug where the Podman frontend is setting a Pids limit of 0 on some rootless systems.
For now, this is only implemented for the PID limit. It can easily be extended to other resource limits, but it is a fair bit of code to do so, so I leave that exercise to someone else.
Fixes #6834