-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --tz flag to create, run #6836
Conversation
@rhatdan PTAL |
@@ -449,6 +449,11 @@ func GetCreateFlags(cf *ContainerCLIOpts) *pflag.FlagSet { | |||
"tty", "t", false, | |||
"Allocate a pseudo-TTY for container", | |||
) | |||
createFlags.StringVar( | |||
&cf.TZ, | |||
"tz", containerConfig.TZ(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do in podman-remote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I haven't done anything in the remote area, should I add the remote implementation to this PR as well? Or save it for another
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't do it here, i would exect you to wire up the tz stuff asap for the api (remote) side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can definitely do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baude uhh it looks like somehow i actually got this wired to the api remote side without knowing i did. pleasant surprise(?)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I see that a lot of the timezones are symlinks in non-Red Hat OSes; we might need to do some sort of resolution on the link to get the correct target. For example: In Debian, the |
@mheon Ooh, thanks, great point! I'll add that in now, a simple IsDir and EvalSymlinks should suffice? |
Yeah, those should be fine |
adaa637
to
c2a0d90
Compare
--tz flag sets timezone inside container Can be set to IANA timezone as well as `local` to match host machine Signed-off-by: Ashley Cui <[email protected]>
LGTM |
/lgtm |
--tz flag sets timezone inside container
Can be set to IANA timezone as well as
local
to match host machineCloses #5128
Signed-off-by: Ashley Cui [email protected]