-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't override entrypoint if it's nil
#6817
fix: Don't override entrypoint if it's nil
#6817
Conversation
Hi @maybe-sybr. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change ensures that we only override a container's entrypoint if it is set to something other than `nil`. Signed-off-by: Matt Brindley <[email protected]>
1c9b5b6
to
aa69e68
Compare
I'm hoping this won't affect any other callers, because it might have been considered valid to set the entrypoint to https://github.com/containers/libpod/blob/b163ec35d0d42423c274019cb41013d558d6f822/cmd/podman/common/specgen.go#L391-L399 So hopefully this is legit |
LGTM. |
I wouldn't worry about other callers. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maybe-sybr, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/hold cancel |
/ok-to-test |
This change ensures that we only override a container's entrypoint if
it is set to something other than
nil
.Fixes #6565