Fix saving in oci format #6814
Fix saving in oci format #6814
Conversation
|
replace #6562 |
libpod/runtime_img.go
Outdated
| @@ -273,7 +274,13 @@ func (r *Runtime) LoadImage(ctx context.Context, name, inputFile string, writer | |||
| newImages, err = r.ImageRuntime().LoadFromArchiveReference(ctx, src, signaturePolicy, writer) | |||
| } | |||
| if err != nil { | |||
| return "", errors.Wrapf(err, "error pulling %q", name) | |||
| src, err := layout.NewReference(inputFile, "") | |||
There was a problem hiding this comment.
@mtrmac PTAL
src, err := layout.NewReference(inputFile, ""), why thepodman load can work with "", but error if pass to name?
unable to pull oci:input_file:alpine: Error initializing source oci:input_file:alpine: no descriptor found for reference "alpine"
There was a problem hiding this comment.
@QiWang19 "" means “verify that the index contains only one manifest, and use that one”. Passing a name allows reading from an index that contains any number of manifests, but the name must match the org.opencontainers.image.ref.name annotation exactly (that annotation is a string with allowed characters and no defined normalization semantics).
So, what’s the value of that annotation in the created index? Is it there at all? Does it perhaps say localhost/alpine or something like that?
There was a problem hiding this comment.
hm,yes, if I load from the oci-dir it was saved, it says localhost/alpine
$ podman save --format oci-dir -o podman-dir alpine
$ podman load -i podman-dir alpine
$ podman images
REPOSITORY TAG IMAGE ID CREATED SIZE
localhost/podman-dir latest 0f5f445df8cc 4 weeks ago 5.85 MB
localhost/alpine latest 0f5f445df8cc 4 weeks ago 5.85 MB
There was a problem hiding this comment.
That’s messy… the local image is named localhost/alpine in c/storage, and we do want to find that image when the user says alpine. So, using the localhost/alpine name when writing to the archive makes some sense.
OTOH when reading from the archive it’s not at all clean to automatically change the name, because the names in OCI don’t have any semantics like that.
Conceptually I think it would be clean to use just alpine when writing to oci-dir:, and because it is basically new with this PR, we could do that — but it is more important to me that oci-dir: and oci-archive: behave consistently, and we can’t quite change the behavior of oci-archive: now.
I suppose we could, when reading from the archive, try both the user input unmodified and user input with localhost/ prepended if there is no registry component.
There was a problem hiding this comment.
Passing a name allows reading from an index that contains any number of manifests, but the name must match the
org.opencontainers.image.ref.nameannotation exactly (that annotation is a string with allowed characters and no defined normalization semantics).
The passing name error happens if org.opencontainers.image.ref.name contains a tag, it this expected?
podman save --format oci-dir -o podman-dir docker.io/library/alpine:3.5
podman load -i podman-dir docker.io/library/alpine:3.5
Error initializing source oci:podman-dir:docker.io/library/alpine: no descriptor found for reference "docker.io/library/alpine"
There was a problem hiding this comment.
That doesn’t look expected — but it also suggests that the tag was stripped somewhere in Podman.
|
/approve |
openshift-ci-robot
added
the
approved
|
@mtrmac PTAL |
QiWang19
force-pushed
the
oci-dir
branch
2 times, most recently
from
85dcc38 to
42ef200
Compare
- fix saving&loading oci format. Close containers#6544 - support loading using image name without "localhost/" prefix when reading from ociarchive/dir saved from this semantics Signed-off-by: Daniel J Walsh <[email protected]> Signed-off-by: Qi Wang <[email protected]>
|
@rhatdan @mheon @vrothberg PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Daniel J Walsh [email protected]
Signed-off-by: Qi Wang [email protected]