Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd system test: run auto-update #6810

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

vrothberg
Copy link
Member

Run podman auto-update in the systemd system tests. Note that this is
a first step to at least exercise parts of auto-update in the CI. The
service won't get updated just yet as we need to set up a local
registry, and push a new image. I do not have enough time at the moment
to do that but consider this change already as an improvement.

We are experiencing some issues in #6793 w.r.t. to auto-updates but
couldn't track down the root cause yet.

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@edsantiago
Copy link
Member

Testing with a local registry will be difficult unless auto-update can be taught to use --tls-verify=false

@vrothberg
Copy link
Member Author

Testing with a local registry will be difficult unless auto-update can be taught to use --tls-verify=false

Good point. We could either extend the CLI and add that as a flag or we create a custom registries.conf where we mark the registry as insecure.

Run `podman auto-update` in the systemd system tests.  Note that this is
a first step to at least exercise parts of `auto-update` in the CI.  The
service won't get updated just yet as we need to set up a local
registry, and push a new image.  I do not have enough time at the moment
to do that but consider this change already as an improvement.

We are experiencing some issues in containers#6793 w.r.t. to auto-updates but
couldn't track down the root cause yet.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

Repushed to get tests running again. GitHub was down today.

@vrothberg
Copy link
Member Author

@mheon, I want this in the v2 branch as well. Just to be sure.

@mheon
Copy link
Member

mheon commented Jun 29, 2020

We really need a backports label...

@TomSweeneyRedHat
Copy link
Member

Changes LGTM
but tests still seem to be dragging.

@vrothberg
Copy link
Member Author

Ready to merge :)

@edsantiago
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit d90e8b6 into containers:master Jun 29, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants