APIv2: Add docker compatible volume endpoints

[maybe-sybr]

This is a WIP for a simple docker compatibility endpoint for volumes in APIv2. Happy to take any feedback on the approach or any admin I'd need to do (CLA?) since this is my first contrib to libpod.

[openshift-ci-robot]

Hi @maybe-sybr. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maybe-sybr]

Related to my question about compat endpoints for volumes at #6720

[mheon]

No CLA required, but all commits do need a Signoff.

[maybe-sybr]

This changeset implements all of the v1.40 endpoints with a few support caveats noted in the commit message. The endpoints work fine when I hit them in a project I'm working on, but I'm not testing many of the edge cases. I'm leaving this as is for now, pending some input from y'all. I'll keep an eye on the PR for any feedback.

[mheon]

@maybe-sybr Let me get a quick handler for the dangling filter written, should be pretty easy

[mheon]

#6756

[maybe-sybr]

@mheon I have a new changeset which uses your dangling filter and also excludes the libpod specific filters. I'll push a HEAD which merges in the current HEAD from #6756 and has that fixup commit for my change. This will obviously need a rebase/autosquash once your merge goes in, or a rebase/autosquash/removal of the merge commit if we want to merge this first and wait for dangling support to land independently.

[maybe-sybr]

Rebased on master, squashed down and I fixed up those swagger model types so they're capital cased/public. I think this will be good to go now.

[maybe-sybr]

The swagger check in gating is complaining at me for changing some of the endpoint lines to match a change it suggested for one of them in a previous run. https://github.com/containers/libpod/pull/6736/checks?check_run_id=824743139

I would have assumed all of these should be either compat (and end up being volumes (compat)in the API docs) or justvolumes` (and some magic takes place?). Any ideas on how to make it happy and have the docs render sensibly?

[vrothberg]

I reads like Swagger wants volumes to be at the end of the lines it complains about

[maybe-sybr]

@vrothberg , check out these two checks and the diff between them:

• https://github.com/containers/libpod/pull/6736/checks?sha=10227dbd9619eba3e2fd3747af05ebbbe9a681d5
• https://github.com/containers/libpod/pull/6736/checks?sha=257f99bc87b73b29e3522f33b3cded1a0f6fb867 (current)
• https://github.com/maybe-sybr/libpod/compare/10227dbd9619eba3e2fd3747af05ebbbe9a681d5..257f99bc87b73b29e3522f33b3cded1a0f6fb867

The way I read that complaint was that initially I needed to change the word volumes to compat on L111, which I did as well as making the same change to lines following it. Now it's complaining about the other lines I changed and wants them to be volumes again.

I think I understand what's happening through - swagger likely wants that word to be the parent of the endpoint being described on that line. So for the top level /volumes endpoint, that's / which is probably assigned to compat somewhere. Then all of the other endpoints live under /volumes so that's their parent and swagger is right to complain when I lie about them being children of the compat "group".

I'm going to make that change now that I have a handle on why it's telling me to do things. Will push a squashed and rebased change momentarily.

[maybe-sybr]

CI looks much happier on the unsquashed version of the diff I just re-pushed. LMK if any other changes need to be made prior to merge.

[vrothberg]

LGTM, thanks a lot for the great work, @maybe-sybr

[vrothberg]

/lgtm
/hold

[vrothberg]

/hold cancel