Add JSON output field for ps #6731
Conversation
the toolbox team needs a field in our ps json that represents a human readable time. Signed-off-by: Brent Baude <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
LGTM |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| @@ -15,6 +15,8 @@ type ListContainer struct { | |||
| Command []string | |||
| // Container creation time | |||
| Created int64 | |||
| // Human readable container creation time. | |||
| CreatedAt string | |||
There was a problem hiding this comment.
I wanted to point out that the Created and CreatedAt fields are switched between ps and images.
In images, Created is the human-friendly string while CreatedAt is the machine-readable form. In ps, they are the other way round.
I don't really mind it. Just wanted to be sure that it's a deliberate decision (for Docker compatibility?).
There was a problem hiding this comment.
Do you know if they are switched in Docker as well?
There was a problem hiding this comment.
Docker does not offer a JSON-formatted output.
github-actions
bot
added
the
locked - please file new issue/PR
the toolbox team needs a field in our ps json that represents a human readable time.
Signed-off-by: Brent Baude [email protected]