document CAP_SYS_ADMIN required for systemd PrivateNetwork

[jamescassell]

This wasn't working for rootful containers either without the --privileged flag. I did some searching and found that CAP_SYS_ADMIN is required for PrivateNetwork feature to work: https://stackoverflow.com/questions/39539188/why-unshareclone-newnet-requires-cap-sys-admin

[openshift-ci-robot]

Hi @jamescassell. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jamescassell]

original "PrivateNetwork doesn't work in rootless" reference in the docs was added in #3972

[rhatdan]

Thanks @jamescassell, but you need to sign your PR.
git commit -a --amend -s
git push --force
LGTM

[vrothberg]

The tests are currently failing because an container image we use in the CI has changed and regressed. Can you rebase the PR on the lastet master? This will unblock CI.

[vrothberg]

LGTM

[jamescassell]

Seems like CI should be testing a merge, not the PR HEAD....

[rhatdan]

@jamescassell Please rebase.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamescassell
To complete the pull request process, please assign mheon
You can assign the PR to them by writing /assign @mheon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

@jamescassell still missing a signature on your commit git commit --amend -s and the gating tests won't let it through until it gets one.

[TomSweeneyRedHat]

Changes LGTM otherwise.

[vrothberg]

@jamescassell can you squash the two commits and repush? That should unblock CI and turn it green.