Add support for image sorting for all options

[jwhonce]

• Sort images for -q option, removing duplicate id's

Fixes #6670

Signed-off-by: Jhon Honce [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jwhonce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

lgtm

[TomSweeneyRedHat]

LGTM
assuming happy tests

[rhatdan]

Can you fix your commit message to something a little more descriptive. This message will be useless in the future.

[vrothberg]

I think we need more tests to make sure all sort keys work.

[vrothberg]

I noticed that --format json doesn't sort either, but already in v1.9.3:

libpod (master) $ /usr/bin/podman images --sort repository --format json
[
    {
        "ID": "1c35c441208254cb7c3844ba95a96485388cef9ccc0646d562c7fc026e04c807",
        "Names": [
            "docker.io/library/busybox:latest"
        ],
        "Created": "2 weeks ago",
        "Digest": "sha256:95cf004f559831017cdf4628aaf1bb30133677be8702a8c5f2994629f637a209",
        "Digests": [
            "sha256:95cf004f559831017cdf4628aaf1bb30133677be8702a8c5f2994629f637a209",
            "sha256:fd4a8673d0344c3a7f427fe4440d4b8dfd4fa59cfabbd9098f9eb0cb4ba905d0"
        ],
        "CreatedAt": "2020-06-02T21:19:57.279412246Z",
        "Size": 1441812,
        "ReadOnly": false,
        "History": []
    },
    {
        "ID": "a24bb4013296f61e89ba57005a7b3e52274d8edd3ae2077d04395f806b63d83e",
        "Names": [
            "docker.io/library/alpine:latest"
        ],
        "Created": "2 weeks ago",
        "Digest": "sha256:185518070891758909c9f839cf4ca393ee977ac378609f700f60a771a2dfe321",
        "Digests": [
            "sha256:185518070891758909c9f839cf4ca393ee977ac378609f700f60a771a2dfe321",
            "sha256:a15790640a6690aa1730c38cf0a440e2aa44aaca9b0e8931a9f2b0d7cc90fd65"
        ],
        "CreatedAt": "2020-05-29T21:19:46.363518345Z",
        "Size": 5849195,
        "ReadOnly": false,
        "History": []
    }
]

I consider that a bug and would love to have that fixed as well. I'd guess that's one more motivation to sort the images at the caller in func images(...).

[baude]

/lgtm