Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Fix remote docs #6673

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

ashley-cui
Copy link
Member

@ashley-cui ashley-cui commented Jun 18, 2020

Fix renaming bug in remote-docs.sh
Remove mentions of 'remote' in windows and mac dos
Remove podman-remote.conf.5

Closes #6584

Signed-off-by: Ashley Cui [email protected]

Fix renaming bug in remote-docs.sh
Remove mentions of 'remote' in windows and mac dos
Remove podman-remote.conf.5

Signed-off-by: Ashley Cui <[email protected]>
@jwhonce
Copy link
Member

jwhonce commented Jun 18, 2020

LGTM

@jwhonce jwhonce changed the title Fix remote docs [CI:DOCS] Fix remote docs Jun 18, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM
assuming happy tests

@@ -132,14 +132,3 @@ the exit codes follow the `chroot` standard, see below:
| [podman-unpause(1)](podman-unpause.1.md) | Unpause one or more containers. |
| [podman-version(1)](podman-version.1.md) | Display the Podman version information. |
| [podman-volume(1)](podman-volume.1.md) | Manage Volumes. |

## FILES
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this with containers.conf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to need the containers.conf man page or a slimmed down one, along with the containers-storage.conf and containers-image.conf man pages.

@vrothberg Back in the day we could not maintain these in vendor directory, is this still true?

@rhatdan
Copy link
Member

rhatdan commented Jun 18, 2020

/approve
/lgtm
I am going to approve for now. @ashley-cui lets open another PR to add information to the podman remote command to explain the containers.conf file.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit a2661b1 into containers:master Jun 18, 2020
@ashley-cui
Copy link
Member Author

I am going to approve for now. @ashley-cui lets open another PR to add information to the podman remote command to explain the containers.conf file.

@rhatdan Sounds good, though you may have to explain what ends up in containers.conf to me first. I looked through and haven't seen any docs on containers.conf?

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making podman-remote-darwin-docs renames manpages incorrectly
6 participants