Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated message to varlink command #6610

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Jun 15, 2020

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce requested a review from mheon June 15, 2020 16:13
@jwhonce jwhonce self-assigned this Jun 15, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@mheon
Copy link
Member

mheon commented Jun 15, 2020

Agree with the deprecation message, but also think we should mark this as hidden to try and force people to podman system service --varlink

@jwhonce jwhonce force-pushed the wip/varlink branch 2 times, most recently from c49f50d to ca7192b Compare June 15, 2020 18:40
* Remove varlink references from the man pages
* Fix signature for extractTarFile()

Signed-off-by: Jhon Honce <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jun 15, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 66b6697 into containers:master Jun 16, 2020
@jwhonce jwhonce deleted the wip/varlink branch June 30, 2021 16:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants