Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default WorkingDir to / on client side #6587

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 12, 2020

Signed-off-by: Daniel J Walsh [email protected]

Fixes #6585

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Jun 12, 2020

@goochjj @jdoss PTAL

@jdoss
Copy link
Contributor

jdoss commented Jun 12, 2020

LGTM!

$ podman version
Version:      2.0.0-dev
API Version:  1
Go Version:   go1.14.3
Git Commit:   2386a2ef2dd3ab4976a3e1dd6d76616e8558d85b
Built:        Fri Jun 12 07:23:57 2020
OS/Arch:      linux/amd64

$ podman run --rm --name redis-testing -p 6379:6379 redis:6.0.1
1:C 12 Jun 2020 12:25:57.161 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
1:C 12 Jun 2020 12:25:57.161 # Redis version=6.0.1, bits=64, commit=00000000, modified=0, pid=1, just started
1:C 12 Jun 2020 12:25:57.161 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf
1:M 12 Jun 2020 12:25:57.162 * Increased maximum number of open files to 10032 (it was originally set to 1024).
1:M 12 Jun 2020 12:25:57.162 * Running mode=standalone, port=6379.
1:M 12 Jun 2020 12:25:57.162 # Server initialized
1:M 12 Jun 2020 12:25:57.162 # WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
1:M 12 Jun 2020 12:25:57.162 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled.
1:M 12 Jun 2020 12:25:57.163 * Ready to accept connections

@goochjj
Copy link
Contributor

goochjj commented Jun 12, 2020

Yep, confirmed fixed.

podman run --rm -it testimage sh
/tmp #

@rhatdan
Copy link
Member Author

rhatdan commented Jun 12, 2020

This led me to find another bug. containers/buildah#2402

@mheon
Copy link
Member

mheon commented Jun 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3f026eb into containers:master Jun 12, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting a redis:6.0.1 container no longer works with podman 2.0.0-dev
6 participants