Do not share container log driver for exec

[mheon]

When the container uses journald logging, we don't want to automatically use the same driver for its exec sessions. If we do we will pollute the journal (particularly in the case of healthchecks) with large amounts of undesired logs. Instead, force exec sessions logs to file for now; we can add a log-driver
flag later (we'll probably want to add a podman logs command that reads exec session logs at the same time).

Fixes #6555

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Should we just drop the logging altogether rather then saving them to a log. Does Docker exec get logged?

[mheon]

Conmon currently requires a log driver. Adding a null log driver to Conmon would alleviate this, but would add a lot of complexity to this simple fix.

[goochjj]

docker exec is never logged (fyi)

[rhatdan]

@haircommander How hard would it be to add the null driver to conmon? Not for this PR but for future ones.

[rhatdan]

@mheon I think you should tell conmon to log to /dev/null then on exec, rather then taking up disk space and having to deal with cleaning it up. Once conmon can handle no log driver or the null driver, we can remove it.

[mheon]

@rhatdan @haircommander My one concern there is breaking log rotation - will conmon try to rotate /dev/null?

[goochjj]

@haircommander How hard would it be to add the null driver to conmon? Not for this PR but for future ones.

I've been all over the conmon source recently - I think it'd be pretty trivial. i.e.

static gboolean use_journald_logging = FALSE;
static gboolean use_k8s_logging = FALSE;

Keeping both of those false, instead of always setting one.

[haircommander]

it should be a simple fix

[goochjj]

@haircommander see containers/conmon#172

[goochjj]

All said - this patch does work - it logs to exec_log and is cleaned up when the process exits.

[goochjj]

@mheon do you want to squash this so the gating check passes....

[mheon]

We actually have a new Conmon out now, so we're expecting that tests should start passing - let me get this passing

[mheon]

Rebased, but could use a few tests for the new functionality, let me add some.

[mheon]

Added a test for the none logdriver. Re-enabled exec tests on ubuntu, which should work now that Conmon 2.0.18 is available in the libcontainers repos.

[mheon]

[+0123s] Error: AppArmor profile "container-default" specified but not loaded on ubuntu, again... I have no idea where this is coming from. Going to restart, hopefully it's an environment issue.

[mheon]

I think they're going to pass this time...
@rhatdan @baude @vrothberg @giuseppe @TomSweeneyRedHat PTAL

[rhatdan]

LGTM

[TomSweeneyRedHat]

LGTM
and happy green test buttons!

[rhatdan]

/lgtm