Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-events: clarify streaming behaviour #6537

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

vrothberg
Copy link
Member

Unless --since or --until is specified, podman events will stream
new events. Clarify this behavior in the --help message and man page
to avoid confusion.

Fixes: #6536
Signed-off-by: Valentin Rothberg [email protected]

@mheon @rhatdan @TomSweeneyRedHat PTAL

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@rhatdan
Copy link
Member

rhatdan commented Jun 9, 2020

LGTM, other then Gating test failure.
@TomSweeneyRedHat @mheon PTAL

Unless `--since` or `--until` is specified, `podman events` will stream
new events.  Clarify this behavior in the `--help` message and man page
to avoid confusion.

Fixes: containers#6536
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

merge me

@mheon
Copy link
Member

mheon commented Jun 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 37c9078 into containers:master Jun 10, 2020
@vrothberg vrothberg deleted the events-docs branch June 10, 2020 13:36
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman events: clarify when it streams
5 participants