Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 enable ubuntu #6515

Merged
merged 3 commits into from
Jun 8, 2020
Merged

V2 enable ubuntu #6515

merged 3 commits into from
Jun 8, 2020

Conversation

vrothberg
Copy link
Member

Meant to replace #6418.

@baude @vrothberg
Enable Ubuntu tests in CI
efd1422 
Add updates required for ubuntu and run integration tests

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@vrothberg vrothberg mentioned this pull request Jun 8, 2020
Closed
@vrothberg
Copy link
Member Author

Don't merge. Added a bad commit but want to let it run to test.

@vrothberg vrothberg changed the title V2 enable ubuntu WIP - V2 enable ubuntu Jun 8, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2020
@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2020

@vrothberg Could you squash your commits. "m" is a very informative commit message, but I have a Q about it. :^)

@vrothberg
Copy link
Member Author

@vrothberg Could you squash your commits. "m" is a very informative commit message, but I have a Q about it. :^)

he, I noticed too but want to wait and see if that turns tests green.

edsantiago
edsantiago approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests are green. I will take it on myself to understand the root of the problem.

hack/install_bats.sh Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
force bats version to v1.1.0
b6148b6 
We experienced regression when using the latest `v1.2.0-dev` bats in
Ubuntu 20.04 (see github.com/containers/pull/6418).  Using
bats v1.1.0 worked in the Ubuntu test VM.

Signed-off-by: Valentin Rothberg <[email protected]>
mheon
mheon reviewed Jun 8, 2020
View reviewed changes
test/e2e/checkpoint_test.go Outdated
@@ -232,6 +232,7 @@ var _ = Describe("Podman checkpoint", func() {
})

It("podman checkpoint container with established tcp connections", func() {
Skip("fails on ubuntu")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a plain Skip? Shouldn't this be a SkipIfNotFedora() too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inherited from #6418 but a good catch! Will update with the next push.

@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests and @mheon's comment is addressed

@edsantiago
Copy link
Member

The BATS failure is an Ubuntu bug: they forked their own BATS and broke it. I've filed an Ubuntu bug

@vrothberg vrothberg changed the title WIP - V2 enable ubuntu V2 enable ubuntu Jun 8, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2020
@vrothberg
Copy link
Member Author

Can someone drop a 'lgtm hold'?

@edsantiago
Copy link
Member

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@edsantiago
Copy link
Member

bindings failed. I'm assuming it's a flake. Restarted.

@vrothberg
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit b8acc85 into containers:master Jun 8, 2020
@vrothberg vrothberg deleted the v2-enable-ubuntu branch June 9, 2020 07:01
@edsantiago edsantiago mentioned this pull request Jun 24, 2020
Closed
@cevich cevich mentioned this pull request Sep 30, 2020
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

@edsantiago edsantiago edsantiago approved these changes

@giuseppe giuseppe Awaiting requested review from giuseppe

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vrothberg @rhatdan @openshift-ci-robot @TomSweeneyRedHat @edsantiago @mheon @openshift-merge-robot @baude