test.apiv2: add test cases for committing an image from a container #6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @chuanchang. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
approved
|
@chuanchang thanks for your contributions! Excellent! |
|
LGTM, but would like a final signoff from @edsantiago |
edsantiago
suggested changes
Jun 2, 2020
Testing query parameters: container, repo, tag, comment, author, changes and pause. Signed-off-by: Alex Jia <[email protected]>
@edsantiago thank you, done, and also added testing for 'changes' query parameter, test result as below. |
edsantiago
approved these changes
Jun 3, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuanchang, edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice work, thank you! /lgtm [Quick suggestion for next time: it is not necessary to paste in test results.] |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jun 3, 2020
- (minor): apiv2 tests: check for full ID Observation made while reviewing containers#6461: tests were checking only for a 12-character container/image ID in return value. It's actually 64, and we should test for that. This should also minimize confusion in a future maintainer. - podman pause/unpause: new test Runs a 'date/sleep' loop, pauses container, sleeps 3s, restarts, then confirms that there's a 3- to 6-second gap in the logs for the container. - podman healthcheck: new test run a container with healthcheck, test both healthy and unhealthy conditions - podman pod: check '{{.Pod}}' field in podman ps Hey, as long as we have a pod with two running containers, might as well confirm that 'podman ps' returns the expected pod ID. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing query parameters: container, repo, tag, comment, author, pause.
Signed-off-by: Alex Jia [email protected]