Combine the code of dealing with 'readonly' and 'ro'.

[schrht]

Combine the code of dealing with 'readonly' and 'ro'.
#6380 (comment)

Signed-off-by: Charles Shih [email protected]

[openshift-ci-robot]

Hi @SCHEN2015. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhatdan]

Filter before image tests is blowing up everywhere?

[mheon]

/ok-to-test

Yeah, I think master may be broken. Investigating...

[mheon]

/approve

For reference, this PR LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, SCHEN2015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

[+0225s] ERROR: unsatisfiable constraints:
[+0225s]   man (missing):
[+0225s]     required by: world[man]
[+0225s] Error: error building at STEP "RUN apk update && apk add man": error while running runtime: exit status 1

This is coming out of podman build

[TomSweeneyRedHat]

doesn't read-only still need to be here?

[schrht]

Tom, thanks for asking.

read-only was in the manual, but this option had never been implemented in the code before.

mheon replaced read-only with readonly in the manual (#6380), I went ahead and removed read-only from the code. As the final result, the readonly is in the manual and code, the same behavior as Docker.

Have a nice day.
Charles

[mheon]

The dockerfile we're trying to build is just one line:

FROM docker.io/library/alpine:latest

[mheon]

Ah, nevermind, wrong test, it's a 2 liner -

FROM docker.io/library/alpine:latest                                                                                                                                                                                                                       
RUN apk update && apk add man

[mheon]

Dockerfile works fine locally, command runs fine in an Alpine image.

[schrht]

/assign @rhatdan

[mheon]

Aha, found the issue. My local machine pulls Alpine 3.11, CI is pulling 3.12 - the upgrade must have broken things

[mheon]

Confirmed, manually pulling 3.12 down, I can replicate

[mheon]

@SCHEN2015 I'm going to make a PR against master to fix CI, then once that merges you'll need to rebase to pick up the fix

[schrht]

@mheon Please go ahead, I will do that. Thank you for the effort!

[mheon]

#6450 to fix CI

[mheon]

Should be good to rebase, master is green again. Thanks!

[rhatdan]

/lgtm

[rhatdan]

Thanks @SCHEN2015 Nice job.