Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile #6393

Merged
merged 1 commit into from
May 26, 2020
Merged

Fix Dockerfile #6393

merged 1 commit into from
May 26, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 26, 2020

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan
Fix Dockerfile
154debb 
Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@baude
Copy link
Member

baude commented May 26, 2020

lgtm

vrothberg
vrothberg reviewed May 26, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM

@baude
Copy link
Member

baude commented May 26, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit d6a7096 into containers:master May 26, 2020
@edsantiago
Copy link
Member

cirrus-flake-summarize, for later analysis:

test fedora-31 fedora-31

2020-05-26T08:42:04 integration_test

2020-05-26T09:22:25 integration_test

2020-05-26T09:50:29 integration_test

@edsantiago edsantiago mentioned this pull request Jun 24, 2020
Closed
@edsantiago edsantiago mentioned this pull request Jan 19, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@mheon mheon Awaiting requested review from mheon

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhatdan @openshift-ci-robot @baude @TomSweeneyRedHat @edsantiago @vrothberg @openshift-merge-robot