Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rmi test #6328

Merged
merged 1 commit into from
May 22, 2020
Merged

Enable rmi test #6328

merged 1 commit into from
May 22, 2020

Conversation

sujil02
Copy link
Member

@sujil02 sujil02 commented May 21, 2020

Enable RMI test.
Signed-off-by: Sujil02 [email protected]

Signed-off-by: Sujil02 <[email protected]>
@jwhonce
Copy link
Member

jwhonce commented May 22, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented May 22, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, sujil02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 398d462 into containers:master May 22, 2020
edsantiago added a commit to edsantiago/libpod that referenced this pull request Aug 19, 2020
info, images, run, networking tests: remove some skip_if_remote()s
that were added in the varlink days. All of these tests now seem
to work with APIv2.

help test: check that first output line from 'podman --help'
is the program description (regression check for containers#7273).

load test: clean up stray images, rewrite test to make it conform
to existing convention. In the process, discover and file containers#7337

exec test (and networking): file containers#7360, and add FIXME comment
to skip()s suggesting evaluating those tests once that is fixed.

pod test: now that containers#6328 is fixed, use 'podman pod inspect --format'
instead of relying on jq

Various other tests: add an explanation of why test is disabled
so we can more easily distinguish "this will never be meaningful
under remote" vs "hey, doesn't work for now, but maybe someday".

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants