Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9] Fix mountpont in SecretMountsWithUIDGID #6282

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 19, 2020

FIPS Mode is failing, because we are attempting to mount the backend
directory from the wrong spot. The parameter is supposed to be
the container image mountpoint not the runtime directory.

Signed-off-by: Daniel J Walsh [email protected]

FIPS Mode is failing, because we are attempting to mount the backend
directory from the wrong spot.  The parameter is supposed to be
the container image mountpoint not the runtime directory.

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@rhatdan
Copy link
Member Author

rhatdan commented May 19, 2020

@vrothberg vrothberg changed the title Fix mountpont in SecretMountsWithUIDGID [1.9] Fix mountpont in SecretMountsWithUIDGID May 20, 2020
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Restarted the flaked tests (Quay was down)

@rhatdan
Copy link
Member Author

rhatdan commented May 20, 2020

@mheon @TomSweeneyRedHat Tests are passing.

@mheon
Copy link
Member

mheon commented May 20, 2020

/lgtm

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@rhatdan rhatdan merged commit c210bb1 into containers:v1.9 May 20, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants