v2 podman remote attach, start, and run #6246
Merged
+54
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the remote client, add the ability to attach to a container, start a container, and run a container. Signed-off-by: Brent Baude <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
| @@ -23,8 +24,7 @@ func StartContainer(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
| if len(query.DetachKeys) > 0 { | |||
| // TODO - start does not support adding detach keys | |||
| utils.BadRequest(w, "detachKeys", query.DetachKeys, errors.New("the detachKeys parameter is not supported yet")) | |||
| return | |||
| logrus.Info("the detach keys parameter is not supported on start container") | |||
There was a problem hiding this comment.
Suggested change
| logrus.Info("the detach keys parameter is not supported on start container") | |
| logrus.Info("the detach keys parameter is not supported on container start") |
| @@ -23,8 +24,7 @@ func StartContainer(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
| if len(query.DetachKeys) > 0 { | |||
| // TODO - start does not support adding detach keys | |||
| utils.BadRequest(w, "detachKeys", query.DetachKeys, errors.New("the detachKeys parameter is not supported yet")) | |||
| return | |||
| logrus.Info("the detach keys parameter is not supported on start container") | |||
There was a problem hiding this comment.
or
Suggested change
| logrus.Info("the detach keys parameter is not supported on start container") | |
| logrus.Info("the detach keys parameter is not supported when starting a container") |
|
LGTM other than one nit |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the remote client, add the ability to attach to a container, start a container, and run a container.
Signed-off-by: Brent Baude [email protected]