network compatibility endpoints for API #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
reviewed
May 15, 2020
|
@vrothberg wrt to tests, i want to "use" this a little with some of the compat stuff to see if it fits the bill. then yes, at that point, tests would be applicable. |
baude
force-pushed
the
v2compatnet
branch
2 times, most recently
from
c29201f to
82d0836
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
jwhonce
reviewed
May 22, 2020
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
add endpoints for networking compatibility with the API. Signed-off-by: Brent Baude <[email protected]>
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Closed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add endpoints for networking compatibility with the API.
Signed-off-by: Brent Baude [email protected]