Fix REMOTETAGS #6230
Merged
Fix REMOTETAGS #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle REMOTETAGS the same way for all remote commands. This fixes issues where remote commands are not building correctly on rhel7 and centos7 systems. Signed-off-by: Daniel J Walsh <[email protected]>
mheon
reviewed
May 14, 2020
| @@ -22,6 +22,7 @@ ETCDIR ?= /etc | |||
| TMPFILESDIR ?= ${PREFIX}/lib/tmpfiles.d | |||
| SYSTEMDDIR ?= ${PREFIX}/lib/systemd/system | |||
| USERSYSTEMDDIR ?= ${PREFIX}/lib/systemd/user | |||
| REMOTETAGS := !ABISupport remoteclient exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper containers_image_openpgp | |||
There was a problem hiding this comment.
Should we use the hack/ scripts to determine whether btrfs, seccomp, etc are included?
There was a problem hiding this comment.
No, We don't want this code compiled into remoteclient. In a perfect world we would not hit this. The btrfs and devicemapper flags are for containers/image and containers/storage and prevent btrfs and devicemapper from being compiled into the client.
|
LGTM assuming happy tests |
mheon
added
approved
|
Manually setting hold and LGTM |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle REMOTETAGS the same way for all remote commands.
This fixes issues where remote commands are not building correctly on rhel7 and centos7 systems.
Signed-off-by: Daniel J Walsh [email protected]