Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Include packages for containers/conmon CI #6193

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Cirrus: Include packages for containers/conmon CI #6193

merged 1 commit into from
Jun 10, 2020

Conversation

cevich
Copy link
Member

@cevich cevich commented May 12, 2020 •
edited
Loading

Depends on: #6201

This allows the containers/conmon repository to share the same VM
images produced by containers/libpod. Included are several packages
which are downloaded only since they might otherwise interfere with
testing for some repos. This allows stable versions to be at the ready
at testing runtime, avoiding any version updates surprising developers.

Signed-off-by: Chris Evich [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2020
@cevich cevich force-pushed the conmon_ci_packages branch from 1e22c31 to 6656cf1 Compare May 12, 2020 19:40
@cevich cevich mentioned this pull request May 12, 2020
Closed
@cevich cevich force-pushed the conmon_ci_packages branch 13 times, most recently from d5afa93 to 41bb0a2 Compare May 14, 2020 18:55
@cevich cevich changed the title WIP: CI:IMG: Cirrus: Include packages for containers/conmon CI Cirrus: Include packages for containers/conmon CI May 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2020
@cevich cevich force-pushed the conmon_ci_packages branch from 41bb0a2 to cadb7ef Compare May 15, 2020 14:47
@cevich cevich changed the title Cirrus: Include packages for containers/conmon CI WIP: CI:IMG: Cirrus: Include packages for containers/conmon CI May 15, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2020
@cevich cevich mentioned this pull request May 15, 2020
Merged
@cevich
Copy link
Member Author

cevich commented May 15, 2020

@haircommander Note while I'm out: For this PR or anything like it (using the CI:IMG magic) doesn't actually need to be merged in order to utilize the output VM Images in the conmon repo. Though eventually having them merged here (and using the new VM images) is desirable from a maintenance perspective (as the instructions for building the images is also changing). This makes it easy to test out changes to images used elsewhere in another PR (like containers/conmon#152), nothing is permanent until merged, and the meta task will do it's job of keeping the active images from being pruned.

The important thing in this PR is: Download fixed-versions of cri-o and kube along with all dependencies, but do not install them (they will break libpod testing). Then in conmon CI, we rpm install the downloaded files. This is to prevent package updates/changes happening at test-runtime, which would open a window of uncertainty and/or introduce unpredictable behavior. That said, you can do runtime package updates/installs, it's not strictly forbidden. just something I like so unrelated development isn't impacted.

Hopefully this all makes sense.

@cevich cevich force-pushed the conmon_ci_packages branch 2 times, most recently from f0685df to 71fb315 Compare May 15, 2020 19:40
@cevich cevich changed the title WIP: CI:IMG: Cirrus: Include packages for containers/conmon CI WIP: Cirrus: Include packages for containers/conmon CI May 15, 2020
@cevich cevich force-pushed the conmon_ci_packages branch from 71fb315 to 781ad9a Compare May 15, 2020 20:27
@cevich cevich changed the title WIP: Cirrus: Include packages for containers/conmon CI Optional: Cirrus: Include packages for containers/conmon CI May 15, 2020
@cevich
Copy link
Member Author

cevich commented May 15, 2020

Removing WIP and marking this as optional. It has changes and new VM images needed by conmon, but nothing immediately required in libpod. It's fine if it sits here until I get back from PTO.

@cevich cevich changed the title Optional: Cirrus: Include packages for containers/conmon CI WIP: CI:IMG: Cirrus: Include packages for containers/conmon CI Jun 9, 2020
@cevich cevich force-pushed the conmon_ci_packages branch from 781ad9a to 0eed080 Compare June 9, 2020 15:06
@cevich cevich changed the title WIP: CI:IMG: Cirrus: Include packages for containers/conmon CI Cirrus: Include packages for containers/conmon CI Jun 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2020
@cevich
Cirrus: Include packages for containers/conmon CI
455a94d 
This allows the containers/conmon repository to share the same VM
images produced by containers/libpod.  Included are several packages
which are downloaded only since they might otherwise interfere with
testing for some repos.  This allows stable versions to be at the ready
at testing runtime, avoiding any version updates surprising developers.

Also, re-enable running the VM-image check test which was not working
due to a logic problem in Cirrus-CI configuration.  Update the neglected
tests so that they pass on all distros.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the conmon_ci_packages branch from 0eed080 to 455a94d Compare June 9, 2020 18:47
@cevich
Copy link
Member Author

cevich commented Jun 9, 2020

Rebased + Rebuilt all VM images.

@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9967f28 into containers:master Jun 10, 2020
@edsantiago edsantiago mentioned this pull request Jun 24, 2020
Closed
@cevich cevich deleted the conmon_ci_packages branch June 30, 2021 18:06
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cevich @rhatdan @openshift-ci-robot @haircommander @openshift-merge-robot