rootlessport: use two different channels #6036
Conversation
Signed-off-by: Giuseppe Scrivano <[email protected]>
The same channel is written to by two different goroutines. Use a different channel for each of them so to avoid writing to a closed channel. Closes: containers#6018 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
|
Can we get a backport to v1.9? |
yes I am going to backport it. Does the /cherry-pick command work in this repo? /cherry-pick 1.9 |
|
no it doesn't, so here it is the PR: #6040 |
|
@cevich Any chance we can get /cherry-pick? |
|
@cevich Any chance we can get /cherry-pick? Hrmmm, not that I know of (by any bot we're currently using). A Github Action could maybe do it but it's not something I've researched. I could guess, but what is the desired behavior when commenting that with a tag or ref? |
|
In the PR that is being merged into master, we do a |
|
CRI-O has this capabillity |
|
oh! okay, that's a helpful hint, I'll go look there. |
|
it's prow magic. I couldn't find a knob to tune in github.com/openshift/release, but I'd guess it's there |
|
Thanks @haircommander I poked around a bit for a Github Action that could replicate this functionality, but haven't found any which don't also require fussing with javascript. The 'do stuff to code, and open a PR' is actually the easy thing to hand-code. The synchronize and responding to comments part is the challenging part - mostly from a 'avoid doing bad/wrong things' perspective. |
|
@rhatdan I'll poke around more as time permits, but this is pretty low on my priority list. My assumption is "nice to have feature" but also "rarely used". If that's wrong, I can make it a higher priority. |
|
I will let @haircommander and @giuseppe comment on that. |
github-actions
bot
added
the
locked - please file new issue/PR
The same channel is written to by two different goroutines.
Use a different channel for each of them so to avoid writing to a closed channel.
Closes: #6018