Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes podman save fails when specifying an image using a digest fixes-5234 #6011

Merged

Conversation

sujil02
Copy link
Member

@sujil02 sujil02 commented Apr 28, 2020

Adds check to parse normalized name and create docker archive dst reference
for tagged untagged image.

Signed-off-by: Sujil02 [email protected]

@sujil02
Copy link
Member Author

sujil02 commented Apr 28, 2020

@mtrmac Thank you for the help.
PTAL

@sujil02 sujil02 changed the title Fixes podman save fails when specifying an image using a digest #5234 Fixes podman save fails when specifying an image using a digest issue-5234 Apr 28, 2020
@sujil02 sujil02 changed the title Fixes podman save fails when specifying an image using a digest issue-5234 Fixes podman save fails when specifying an image using a digest fixes-5234 Apr 28, 2020
libpod/image/image.go Outdated Show resolved Hide resolved
libpod/image/image.go Outdated Show resolved Hide resolved
libpod/image/image.go Outdated Show resolved Hide resolved
@sujil02 sujil02 force-pushed the podman-save-issue-5234 branch from 1e78fc1 to d5b1f73 Compare April 28, 2020 18:35
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(Should there be tests for the newly working functionality?)

…iners#5234

Adds check to parse normalized name and create docker archive dst reference
for tagged untagged image. Relevant test case added.

Signed-off-by: Sujil02 <[email protected]>
@sujil02 sujil02 force-pushed the podman-save-issue-5234 branch from d5b1f73 to 38eb9f4 Compare April 28, 2020 20:16
@sujil02
Copy link
Member Author

sujil02 commented Apr 28, 2020

LGTM.

(Should there be tests for the newly working functionality?)

Added test. PTAL

@rhatdan
Copy link
Member

rhatdan commented Apr 28, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, rhatdan, sujil02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit dcac908 into containers:master Apr 28, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants