-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate healthcheck and container log paths #6009
Conversation
instead of using the container log path to derive where to put the healthchecks, we now put them into the rundir to avoid collision of health check log files when the log path is set by user. Fixes: containers#5915 Signed-off-by: Brent Baude <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/lgtm |
Should this be back ported to podman v1.9? |
Oh, sad to see it moving back in a location hard to share across containers. Anyway, as long as it solves the issue, it's good for me :). |
Yes, please. We'll need it backported into RHEL 8.x if possible so our healthchecks are correctly logged again. Thanks |
guys were are way ahead of you ... see #6008 |
Thanks ;-) |
instead of using the container log path to derive where to put the healthchecks, we now put them into the rundir to avoid collision of health check log files when the log path is set by user.
Fixes: #5915
Signed-off-by: Brent Baude [email protected]