Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate healthcheck and container log paths #6009

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

baude
Copy link
Member

@baude baude commented Apr 27, 2020

instead of using the container log path to derive where to put the healthchecks, we now put them into the rundir to avoid collision of health check log files when the log path is set by user.

Fixes: #5915

Signed-off-by: Brent Baude [email protected]

instead of using the container log path to derive where to put the healthchecks, we now put them into the rundir to avoid collision of health check log files when the log path is set by user.

Fixes: containers#5915

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@mheon
Copy link
Member

mheon commented Apr 27, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Apr 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@rhatdan
Copy link
Member

rhatdan commented Apr 27, 2020

Should this be back ported to podman v1.9?

@openshift-merge-robot openshift-merge-robot merged commit ebf0416 into containers:master Apr 27, 2020
@cjeanner
Copy link

Oh, sad to see it moving back in a location hard to share across containers. Anyway, as long as it solves the issue, it's good for me :).
I think it should be backported to 1.9 as well.

@EmilienM
Copy link
Contributor

Should this be back ported to podman v1.9?

Yes, please. We'll need it backported into RHEL 8.x if possible so our healthchecks are correctly logged again.

Thanks

@baude
Copy link
Member Author

baude commented Apr 28, 2020

guys were are way ahead of you ... see #6008

@EmilienM
Copy link
Contributor

guys were are way ahead of you ... see #6008

Thanks ;-)

@baude baude deleted the v2hclog branch May 18, 2022 15:20
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native healthchecks are unreliable/inconsistent
7 participants