Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in messages pod rm #5991

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix typos in messages pod rm #5991

merged 1 commit into from
Apr 28, 2020

Conversation

sujil02
Copy link
Member

@sujil02 sujil02 commented Apr 26, 2020 •
edited
Loading

Fix typos in messages

Signed-off-by: Sujil02 [email protected]

vrothberg
vrothberg reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #5997) made this pull request unmergeable. Please resolve the merge conflicts.

vrothberg
vrothberg reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

May already be fixed in master now.

@sujil02
Copy link
Member Author

sujil02 commented Apr 27, 2020

@giuseppe rm pod fixes got merged with #5997 should I close this one? however, it has some help message typos fixed.

@sujil02 sujil02 changed the title Enables pod rm itegration test Fix typos in messages pod rm Apr 27, 2020
@sujil02 sujil02 requested a review from vrothberg April 27, 2020 17:21
@rhatdan
Copy link
Member

rhatdan commented Apr 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@sujil02
Fix typos in rm messages
b3cfb20 
Fix typos in pod rm messages

Signed-off-by: Sujil02 <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@sujil02
Copy link
Member Author

sujil02 commented Apr 28, 2020

@rhatdan I accidentally pushed to this branch thought this was merged. no new changes are done. need lgtm again.

@rhatdan
Copy link
Member

rhatdan commented Apr 28, 2020

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Apr 28, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, sujil02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 30b2781 into containers:master Apr 28, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

@jwhonce jwhonce Awaiting requested review from jwhonce

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sujil02 @rh-atomic-bot @vrothberg @rhatdan @openshift-ci-robot @openshift-merge-robot