Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return labes in API (fixes #5882) #5883

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

abitrolly
Copy link
Contributor

I couldn't test it yet. The main why about the code is the what is the difference between info.Labels and info.Config.Labels?

@openshift-ci-robot
Copy link
Collaborator

Hi @abitrolly. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2020
@rhatdan
Copy link
Member

rhatdan commented Apr 19, 2020

@abitrolly You need to sign your PR.

@rhatdan
Copy link
Member

rhatdan commented Apr 20, 2020

@baude @jwhonce PTAL

@baude
Copy link
Member

baude commented Apr 20, 2020

this is @jwhonce code, he will need to look at this.

@TomSweeneyRedHat
Copy link
Member

@abitrolly Can I ask that you fix a title nit please? "Labes" -> "Labels"

@jwhonce
Copy link
Member

jwhonce commented Apr 20, 2020

/ok-to-test
LGTM

@openshift-ci-robot openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2020
@baude
Copy link
Member

baude commented Apr 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@baude
Copy link
Member

baude commented Apr 21, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abitrolly, baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 89276a5 into containers:master Apr 21, 2020
@abitrolly abitrolly deleted the patch-3 branch April 21, 2020 00:48
@abitrolly
Copy link
Contributor Author

@TomSweeneyRedHat I had no chance - libpod project merges too fast. :D

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants