Do not error on pids.current stats if ctr.path is empty #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
force-pushed
the
pids.current
branch
from
d08b89a to
abaeb87
Compare
|
Looks like 3 flakes (two networking pulling images, Podman RMI with cached images in special_testing_rootless). Restarted the lot. |
|
LGTM but want a signoff from @giuseppe before we merge |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
giuseppe
reviewed
Apr 6, 2020
If the ctr.path is empty, then we do not try to access `/sys/fs/cgroup/pids/pids.current` any more because this path will be wrong in any case. We now return and do not set the PIDs stats. Refers to cri-o/cri-o#3522 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
pids.current
branch
from
abaeb87 to
7864afd
Compare
|
thanks, LGTM |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Hey, can we create a new patch release containing this fix? |
|
We are planning on releasing podman-1.9.0-rc1 today or Monday. |
|
Sounds good, thank you! 🙏 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ctr.path is empty, then we do not try to access
/sys/fs/cgroup/pids/pids.currentany more because this path will bewrong in any case. We now return and do not set the PIDs stats.
Refers to cri-o/cri-o#3522
/assign @giuseppe