Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podmanv2 checkpoint and restore #5638

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

baude
Copy link
Member

@baude baude commented Mar 27, 2020

add the ability to checkpoint and restore containers on v2podman

Signed-off-by: Brent Baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@baude baude force-pushed the v2containercheck branch from 829e77f to b33b41f Compare March 27, 2020 13:58
@mheon
Copy link
Member

mheon commented Mar 27, 2020

Suggestion: strip import/export and do them in a separate PR, rest is probably ready to merge as is.

@baude baude force-pushed the v2containercheck branch from b33b41f to 6aa1efd Compare March 27, 2020 14:06
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4698) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020
@baude baude force-pushed the v2containercheck branch from 6aa1efd to 84b7c08 Compare April 3, 2020 13:30
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2020
add the ability to checkpoint and restore containers on v2podman

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the v2containercheck branch from 84b7c08 to 8a16674 Compare April 3, 2020 14:32
@baude
Copy link
Member Author

baude commented Apr 3, 2020

ready for merge

@mheon
Copy link
Member

mheon commented Apr 3, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Apr 3, 2020

I want @adrianreber to make sure this works but It LGTM now. Just so we can get to testing.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 64cade0 into containers:master Apr 3, 2020
@baude baude deleted the v2containercheck branch May 18, 2022 15:21
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants