Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podmanv2 add pre-run to each commmand #5614

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

baude
Copy link
Member

@baude baude commented Mar 26, 2020

each container command needs a prerune because it is not part of the containers subcommand yet

Signed-off-by: Brent Baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
each container command needs a prerune because it is not part of the containers subcommand yet

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the v2containersfix branch from bafa037 to 06e2a5d Compare March 26, 2020 00:24
@jwhonce
Copy link
Member

jwhonce commented Mar 26, 2020

/hold
/lgtm

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2020

LGTM

@baude
Copy link
Member Author

baude commented Mar 26, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit c869b96 into containers:master Mar 26, 2020
@baude baude deleted the v2containersfix branch May 18, 2022 15:21
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants