fix reported compat issues

[baude]

honor -1 in in list containers for compatibility mode. it is commonly used to indicate no limit.

change the json id parameter to Id in container create.

Fixes: #5553

Signed-off-by: Brent Baude [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[rhatdan]

@mheon @jwhonce @edsantiago PTAL

[mheon]

/hold
/lgtm

[TomSweeneyRedHat]

LGTM

[max-arnold]

Are these other occurrencies of lowercase id also should beId?

libpod/pkg/api % grep -r '"id"' .
./handlers/compat/images.go:		Id             string            `json:"id"`
./handlers/compat/images.go:		Id             string            `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID             string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID     string       `json:"id"`
./handlers/utils/containers.go:	ID string `json:"id"`

[baude]

Are these other occurrencies of lowercase id also should beId?

libpod/pkg/api % grep -r '"id"' .
./handlers/compat/images.go:		Id             string            `json:"id"`
./handlers/compat/images.go:		Id             string            `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID             string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID     string       `json:"id"`
./handlers/utils/containers.go:	ID string `json:"id"`

the only questionable ones i see for certain are the compat ones ... does the consumer side of those expect Id?

[edsantiago]

Wouldn't >= 0 be safer?

[rhatdan]

Yes, then if user sends any negative number it will work.

[max-arnold]

To be honest, I haven’t looked how those ids are named in the Docker API spec. It is just a list of other possible occurrences to cross-check

[jwhonce]

Are these other occurrencies of lowercase id also should beId?

libpod/pkg/api % grep -r '"id"' .
./handlers/compat/images.go:		Id             string            `json:"id"`
./handlers/compat/images.go:		Id             string            `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID             string `json:"id"`
./handlers/types.go:	ID string `json:"id"`
./handlers/types.go:	ID     string       `json:"id"`
./handlers/utils/containers.go:	ID string `json:"id"`

the only questionable ones i see for certain are the compat ones ... does the consumer side of those expect Id?

If the /libpod tree doesn't follow the same naming WRT to common fields then bindings with case sensitive json keys won't port without a rewrite. A quick look this morning seems to be "id" for path queries and "Id" for responses.

[baude]

/hold cancel