Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 podman command #5546

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Mar 18, 2020

  • New Domain Objects
  • New Engine access bindings
  • Podman V2 command using above

In V2 to find all logic regarding a command follow path, for example:
cmd/podmanV2/images/list.go or cmd/podmanV2/containers/container.go

Some commands are really aliases, podman images vs podman image list. The aliasing command may reference the cobra.Command{} of the source command. Other cross references should be avoided.

Note:

  1. To allow podman V1 and V2 to live in the same repository. Types or code may be duplicated for a time. New build tags are packages are used to segregate the code as well.
  2. PodmanV2 will allow for two modes of building, in support of:
    • remote clients using ssh tunnels
    • local services using either ssh tunnels or the embedded library

TODO:

  • root/rooless configuration
  • finish all domain objects/types
  • api handlers ported to domain objects
  • bindings ported to domain objects
  • v1 business logic copied into v2 commands

Signed-off-by: Jhon Honce [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@jwhonce jwhonce force-pushed the wip/entities branch 2 times, most recently from 9cef288 to cf621df Compare March 18, 2020 23:10
Signed-off-by: Jhon Honce <[email protected]>
@baude baude changed the title [WIP] V2 podman command V2 podman command Mar 19, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2020
@baude
Copy link
Member

baude commented Mar 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 093d9ef into containers:master Mar 19, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants