Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in containers/buildah v1.14.3 #5542

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 18, 2020

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Mar 18, 2020

Need this for podman 1.8.2 release.
@mheon @TomSweeneyRedHat @QiWang19 @baude @giuseppe @vrothberg PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Mar 18, 2020

@edsantiago podman info should never show a -dev branch for Buildah.

@mheon
Copy link
Member

mheon commented Mar 18, 2020

LGTM

@edsantiago
Copy link
Member

@edsantiago podman info should never show a -dev branch for Buildah.

I'm missing some context here. I recall discussing this a few weeks ago, in the context of a released podman should never show -dev. The implication I see in the above is that no podman ever should show -dev, is that correct? If the latter is correct, that should be easy to test, and I can write a hook for it. For the former, the conversation stalled because I was not aware of a reliable way to identify "this tag/build/pr is intended for release". @cevich is currently doing some promising work along those lines, though.

If my "no podman ever" interpretation is the right one, please let me know and I will add a CI test that blocks -dev in any committed buildah in any PR.

@TomSweeneyRedHat
Copy link
Member

LGTM once tests are happy.
@edsantiago We should keep "buildah*-dev" out of a final Podman release, but I think it's OK on a rare occasion for upstream and even RC releases. Just hope we don't slip up an let one slip through tp a final though.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 18, 2020

@edsantiago No this is the discussion we had a few weeks ago, wanted to make sure rc1 was failing your release testing.

@baude
Copy link
Member

baude commented Mar 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit bd9386d into containers:master Mar 18, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants