-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor in containers/buildah v1.14.3 #5542
Conversation
Signed-off-by: Daniel J Walsh <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Need this for podman 1.8.2 release. |
@edsantiago podman info should never show a -dev branch for Buildah. |
LGTM |
I'm missing some context here. I recall discussing this a few weeks ago, in the context of a released podman should never show -dev. The implication I see in the above is that no podman ever should show -dev, is that correct? If the latter is correct, that should be easy to test, and I can write a hook for it. For the former, the conversation stalled because I was not aware of a reliable way to identify "this tag/build/pr is intended for release". @cevich is currently doing some promising work along those lines, though. If my "no podman ever" interpretation is the right one, please let me know and I will add a CI test that blocks -dev in any committed buildah in any PR. |
LGTM once tests are happy. |
@edsantiago No this is the discussion we had a few weeks ago, wanted to make sure rc1 was failing your release testing. |
/lgtm |
Signed-off-by: Daniel J Walsh [email protected]