Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update rootless_tutorial.md #5428

Closed
wants to merge 1 commit into from
Closed

doc: update rootless_tutorial.md #5428

wants to merge 1 commit into from

Conversation

simon04
Copy link

@simon04 simon04 commented Mar 9, 2020

Most changes are typographic improvements, in particular using using ` for commands/files.

@mheon
Copy link
Member

mheon commented Mar 9, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, simon04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@mheon
Copy link
Member

mheon commented Mar 9, 2020

LGTM

@mheon
Copy link
Member

mheon commented Mar 9, 2020

Looks like you're missing a signoff - please add one with git commit --amend -s and re-push and CI should go green.

@simon04
Copy link
Author

simon04 commented Mar 9, 2020

Done. (I always miss this step when doing commits/PRs directly from the GitHub website.)

@rhatdan
Copy link
Member

rhatdan commented Mar 9, 2020

Yes we are looking into ways to make this automatic, but we have found nothing in github.com...

@rhatdan
Copy link
Member

rhatdan commented Mar 9, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #5427) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2020
@openshift-ci-robot
Copy link
Collaborator

@simon04: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TomSweeneyRedHat
TomSweeneyRedHat reviewed Mar 9, 2020
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 11, 2020

@simon04 This needs a rebase.

@simon04 simon04 closed this Apr 5, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simon04 @mheon @openshift-ci-robot @rhatdan @rh-atomic-bot @TomSweeneyRedHat