Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in latest containers/buildah #5338

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

umohnani8
Copy link
Member

Pulls in fix that sets the correct ownership on
the working directory during the build process.

Signed-off-by: Urvashi Mohnani [email protected]

Pulls in fix that sets the correct ownership on
the working directory during the build process.

Signed-off-by: Urvashi Mohnani <[email protected]>
@umohnani8
Copy link
Member Author

@mheon @baude @rhatdan PTAL
We need this in the release branches as well for the various RHEL versions, which branches should I port it too?

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Feb 27, 2020
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But another gentle reminder that we'll need to spin up and vendor a released Buildah before releasing the next Podman.

@mheon
Copy link
Member

mheon commented Feb 27, 2020

We should not do a complete revendor for Buildah on stable branches; we want to just include the one patch in question. As for where, we should talk at scrum about what requirements are.

@mheon
Copy link
Member

mheon commented Feb 27, 2020

@TomSweeneyRedHat We're planning on cutting Podman 1.8.1 tomorrow or Monday, so we might want to think about making that soon?

@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 25d29f9 into containers:master Feb 27, 2020
@umohnani8 umohnani8 deleted the vendor-buildah branch October 27, 2020 14:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants