Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor of buildah and containers/common #5297

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 22, 2020

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2020
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 22, 2020
@TomSweeneyRedHat
Copy link
Member

Changes LGTM, but it looks like the gitvalidation here picked up something that the c/common didn't:

[+0001s] CGO_ENABLED=0 GOOS=windows GO111MODULE=on go build -mod=vendor -gcflags 'all=-trimpath=/go/src/github.com/containers/libpod' -asmflags 'all=-trimpath=/go/src/github.com/containers/libpod' -ldflags '-X github.com/containers/libpod/libpod/define.gitCommit=71d4ac50f85ff47b0dacb39b5f6fb117cf837e75 -X github.com/containers/libpod/libpod/define.buildInfo=1582367787 -X github.com/containers/libpod/libpod/config._installPrefix=/usr/local -X github.com/containers/libpod/libpod/config._etcDir=/etc -extldflags ""' -tags "remoteclient containers_image_openpgp exclude_graphdriver_devicemapper" -o bin/podman-remote-windows.exe github.com/containers/libpod/cmd/podman
[+0036s] # github.com/containers/buildah
[+0036s] vendor/github.com/containers/buildah/common.go:97:23: undefined: unix.Errno
[+0036s] vendor/github.com/containers/buildah/common.go:98:15: undefined: unix.ECONNREFUSED
[+0036s] make: *** [Makefile:205: podman-remote-windows] Error 2

@rhatdan
Copy link
Member Author

rhatdan commented Feb 25, 2020

Hopefully tests will pass now.
@TomSweeneyRedHat @giuseppe @vrothberg @mheon @baude @jwhonce @QiWang19 PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM

@giuseppe
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3d37dc6 into containers:master Feb 25, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants