search test on fedora registry: retry 5 times #5284
Conversation
test/e2e/search_test.go
Outdated
| @@ -165,8 +166,16 @@ registries = ['{{.Host}}:{{.Port}}']` | |||
| }) | |||
|
|
|||
| It("podman search v2 registry with empty query", func() { | |||
| search := podmanTest.Podman([]string{"search", "registry.fedoraproject.org/"}) | |||
| search.WaitWithDefaultTimeout() | |||
| var search | |||
There was a problem hiding this comment.
Compiler is yelling because it's not sure what type this is... I'm honestly not either. You might need to make this search := podmanTest.Podman(...) so the compiler infers the type
There was a problem hiding this comment.
I'm honestly not either.
Oh, thank you. I've been pulling my hair out trying to figure out the type (I can't get ginkgo working on my laptop, so I can't experiment either).
If I use := won't it fall out of scope outside the for loop? /me doesn't grok golang.
There was a problem hiding this comment.
var search *PodmanSessionIntegration
There was a problem hiding this comment.
Yeah, := is just sugar for var $NAME <inferred type> = ...
There was a problem hiding this comment.
@mheon, I know that much^Wlittle about Go; my question was, doesn't := declare within curlybrace scope? If I did session := ..., could I use session in the two Expect()s below?
There was a problem hiding this comment.
Yes - it'll leak into the sub-scope created by the curly braces (though you can declare another session within that sub-scope to shadow it in there).
There was a problem hiding this comment.
I'm still not using the right words. Let me try this way. Will this work? I wouldn't expect it to.
for .... {
myvar := autodeclared
....
}
if myvar ... // <<---- referencing myvar outside of the above "for" scopeThere was a problem hiding this comment.
PS thank you @rhatdan, that seems to be getting it much further along.
...to try to compensate for flaky host. registry.fedoraproject.org is just not reliable. It's flaking with 503 errors, causing massive amounts of wasted CI time and developer effort. There is exactly one instance of that registry in these tests. We can't replace it with quay.io, because "search quay.io/" (trailing slash) fails with some sort of authentication error. So let's just try a sleep/retry cycle instead. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
flaky_fedora_registry
branch
from
d6d56e4 to
bb31d35
Compare
|
LGTM |
|
Neither test ( |
|
/lgtm |
jwhonce
added
the
approved
|
/approve Not sure what's going on here... |
|
githubstatus.com is reporting a recently (minutes ago) resolved issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, mheon, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
...to try to compensate for flaky host.
registry.fedoraproject.org is just not reliable. It's flaking
with 503 errors, causing massive amounts of wasted CI time
and developer effort.
There is exactly one instance of that registry in these tests.
We can't replace it with quay.io, because "search quay.io/"
(trailing slash) fails with some sort of authentication error.
So let's just try a sleep/retry cycle instead.
Signed-off-by: Ed Santiago [email protected]