podman-ps: support image IDs #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
vrothberg
force-pushed
the
ps-image-id
branch
from
8e92078 to
a812df6
Compare
|
LGTM |
docs/source/markdown/podman-ps.1.md
Outdated
| @@ -55,7 +55,8 @@ Valid placeholders for the Go template are listed below: | |||
| | **Placeholder** | **Description** | | |||
| | --------------- | ------------------------------------------------ | | |||
| | .ID | Container ID | | |||
| | .Image | Image ID/Name | | |||
| | .Image | Image Name/ID | | |||
| | .ImageD | Image ID | | |||
There was a problem hiding this comment.
Did you mean 'ImageD' instead of 'ImageID'?
There was a problem hiding this comment.
Good catch! fixed now :)
Support printing image IDs via `--format "{{.ImageID}}"`.
Fixes: containers#5160
Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
ps-image-id
branch
from
a812df6 to
3c2cc67
Compare
|
LGTM |
|
/lgtm |
openshift-ci-robot
added
do-not-merge/hold
|
Adding an LGTM |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support printing image IDs via
--format "{{.ImageID}}".Fixes: #5160
Signed-off-by: Valentin Rothberg [email protected]