images --format compatible with docker #5115
Conversation
|
LGTM but would prefer to hold until after 1.8.0 so I don't need to update release notes again |
QiWang19
force-pushed
the
images-format
branch
from
f79a20b to
e3dcf7a
Compare
|
Any man page changes? Tests? |
We can add man pages like this https://docs.docker.com/engine/reference/commandline/images/#format-the-output |
|
Looks like the same test errors here as in some other PRs. Houston we may have a CI problem. |
| CreatedSince string | ||
| Size string | ||
| ReadOnly bool | ||
| History string |
There was a problem hiding this comment.
Just wondering if we should still support "Created" and "CreatedTime" in case people have adjusted and have built dependencies on those? I'd be fine if they were hidden options going forward, available for use, but not documented.
There was a problem hiding this comment.
My concern is that keeping Created and CreatedTime in this struct for hidden options seems duplicate.
There was a problem hiding this comment.
yep, it's certainly a duplicate and I'd add a comment in the code as to why it's there. My concern is someone out there has already built a dependency on one of those and we might break them if they go away.
There was a problem hiding this comment.
I would not retain duplicates in the structures - especially given how similar all these names are. We may want to look into normalization similar to what we're doing in podman inspect --format though.
There was a problem hiding this comment.
@TomSweeneyRedHat @mheon Thanks. I will do that.
There was a problem hiding this comment.
If Matt's hip, then I'm hip. Thanks for the discussion!
|
definitely double check on the man pages and tests. If we do drop the old names, we will need a BIG announcement in the 1.8.1 or 1.9.0 Release announcement about that. |
QiWang19
force-pushed
the
images-format
branch
from
e3dcf7a to
b59de5e
Compare
|
LGTM |
This patch lets valid values of --format be compatible with docker. Replace CreatedTime with CreatedAt, Created with CreatedSince. Keep CreatedTime and Created are valid as hidden options. Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
images-format
branch
from
b59de5e to
3afd1b5
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Let valid values of --format be compatible with docker. Replace CreatedTime with CreatedAt, Created with CreatedSince.
fix #5110
Signed-off-by: Qi Wang [email protected]