Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close tarSource when finished using it #5085

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Close tarSource when finished using it #5085

merged 1 commit into from
Feb 4, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 4, 2020

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Feb 4, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Feb 4, 2020

@mtrmac @vrothberg PTAL

mtrmac
mtrmac approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Thanks! Wow, that was quick.)

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Feb 4, 2020

@mheon @baude @TomSweeneyRedHat @QiWang19 PTAL

@mheon
Copy link
Member

mheon commented Feb 4, 2020

LGTM once things go green

@mheon
Copy link
Member

mheon commented Feb 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5092c07 into containers:master Feb 4, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtrmac mtrmac mtrmac approved these changes

@baude baude Awaiting requested review from baude

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhatdan @openshift-ci-robot @mheon @mtrmac @openshift-merge-robot