Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v1.8.0-rc1 #5041

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Bump to v1.8.0-rc1 #5041

merged 2 commits into from
Jan 31, 2020

Conversation

mheon
Copy link
Member

@mheon mheon commented Jan 31, 2020

As the title says

mheon added 2 commits January 31, 2020 12:44
@mheon
Bump to v1.8.0-rc1
5558c26 
Signed-off-by: Matthew Heon <[email protected]>
@mheon
Bump to v1.8.0-dev
a98c36d 
Signed-off-by: Matthew Heon <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Jan 31, 2020
@rhatdan
Copy link
Member

rhatdan commented Jan 31, 2020

LGTM

@baude
Copy link
Member

baude commented Jan 31, 2020

/hold
/lgtm

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@mheon
Copy link
Member Author

mheon commented Jan 31, 2020

Gating is green, and this is rebased against latest master - I think we must have other problems if it's red elsewhere

@mheon
Copy link
Member Author

mheon commented Jan 31, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4699d5e into containers:master Jan 31, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mheon @openshift-ci-robot @rhatdan @baude @openshift-merge-robot