Automatically execute podman-remote if vars set #4981

afbjorklund · 2020-01-26T17:45:46Z

If any of PODMAN_HOST or PODMAN_VARLINK_BRIDGE are set,
then execute "podman-remote" rather than this "podman".

Example:

$ ./bin/podman version
Version:            1.7.1-dev
RemoteAPI Version:  1
Go Version:         go1.13.6
Git Commit:         263432b1db60013d5f871f371112f75e2024c88e
Built:              Sun Jan 26 18:43:10 2020
OS/Arch:            linux/amd64
$ eval $(podman-machine env --varlink)
$ ./bin/podman version
Client:
Version:            1.7.0
RemoteAPI Version:  1
Go Version:         go1.13.6
Git Commit:         b7ce1157b00af09f4a09e39b377aa3abff46ee05
Built:              Sat Jan 18 15:26:34 2020
OS/Arch:            linux/amd64

Server:
Version:            1.7.1-dev
RemoteAPI Version:  1
Go Version:         go1.12.10
Git Commit:         ce4bf33ccc80819f199bdbb6526b9adee1ad41b0-dirty
Built:              Sat Jan 18 11:01:17 2020
OS/Arch:            linux/amd64

Closes #4390

openshift-ci-robot · 2020-01-26T17:45:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To complete the pull request process, please assign mrunalp
You can assign the PR to them by writing /assign @mrunalp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-01-26T17:46:02Z

Hi @afbjorklund. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afbjorklund · 2020-01-26T18:57:26Z

Hmm, think I messed up the error reporting when I made it into a function:

$ ./bin/podman run busybox true
$ ./bin/podman run busybox false
Error running /usr/local/bin/podman-remote: exit status 1

If any of PODMAN_HOST or PODMAN_VARLINK_BRIDGE are set, then execute "podman-remote" rather than this "podman". Also support PODMAN_VARLINK_ADDRESS for tunneling, even though there is no encryption support in such addresses. Signed-off-by: Anders F Björklund <[email protected]>

afbjorklund · 2020-01-26T19:14:19Z

Forgot PODMAN_VARLINK_ADDRESS, which was used in the documentation...

TomSweeneyRedHat · 2020-01-27T15:21:38Z

/ok-to-test

TomSweeneyRedHat · 2020-01-27T15:23:59Z

cmd/podman/main_local.go

+	bridge := os.Getenv("PODMAN_VARLINK_BRIDGE")
+	address := os.Getenv("PODMAN_VARLINK_ADDRESS")
+	if host != "" || bridge != "" || address != "" {
+		program := "podman-remote"


It might be good to have a debug statement in here to just say "Attempting to connect to remote Podman" or some such. I could see it as being potentially helpful in a debugging situation later on.

So something like a logrus.Debugf with the command being executed perhaps.

Tried adding logging, but it doesn't show up in the logs (at the debug level)

@TomSweeneyRedHat : apparently this (init) happens before logging has been set up

That is, we are still running with the default log level of InfoLevel (hiding the debug logging)

vrothberg · 2020-02-12T12:29:12Z

Friendly ping.

afbjorklund · 2020-02-12T16:22:12Z

Not sure if there’s anything more that can be done here, or if we should continue to rename the binary...

afaik it is called "podman" on Mac and Win, so maybe we need to put it in a weird PATH on Linux ?

afbjorklund · 2020-02-12T16:36:17Z

We are currently missing newer podman-remote binaries as well, so there's nothing to execute.

i.e. as we saw else where, the Linux download is missing and the others are stuck at 1.6.x still

github-actions · 2020-03-14T00:05:34Z

A friendly reminder that this PR had no activity for 30 days.

rhatdan · 2020-03-16T12:47:26Z

@afbjorklund Still working on this?

afbjorklund · 2020-03-16T17:39:58Z

@rhatdan : No, I am not sure what kind of logging that @TomSweeneyRedHat wanted ?

If we output something, that will break users (the same way that the docker wrapper does)
And the logging isn't set up yet, since we call this in the init before we set up logging

I think we just went with everybody using podman-remote for the binary name instead...

https://minikube.sigs.k8s.io/docs/tasks/podman_service/

eval $(minikube podman-env)

podman-remote help

vrothberg · 2020-05-04T14:29:46Z

I am going through open pull requests at the moment. Apologies for not getting this in earlier!

Much has changed since this PR was opened and while it doesn't apply as is anymore, we can still use the idea. The new remote client is talking to Podman's new rest API, so we can ignore varlink. But auto-detecting PODMAN_HOST and using the remote backend could easily be done by adding a host-env check to https://github.com/containers/libpod/blob/master/cmd/podman/registry/config.go#L40.

@baude @jwhonce WDYT?

afbjorklund · 2020-05-04T16:47:02Z

Much has changed since this PR was opened and while it doesn't apply as is anymore, we can still use the idea. The new remote client is talking to Podman's new rest API, so we can ignore varlink.

We have already adopted to the existing policy of podman being native on Linux and remote on Mac and Windows ("not available" on Linux), and using varlink and sudo for the access model.

afbjorklund · 2020-05-04T16:53:22Z

I will close this PR, and you can make a new one for the new cilent (for the same original issue).

We still have some issues with the documentation being "blank" and the > 1.6 binaries missing ?

So it seems to be a lot more than just the name of the program that will need some rework here...

Can continue the "podman-remote" discussion in the #4390 issue instead of here, if needed.

openshift-ci-robot requested review from giuseppe and mheon January 26, 2020 17:45

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M labels Jan 26, 2020

afbjorklund requested review from jwhonce and baude January 26, 2020 17:46

afbjorklund force-pushed the podman-remote branch from 263432b to 7dbfbfb Compare January 26, 2020 19:01

afbjorklund force-pushed the podman-remote branch from 7dbfbfb to 4d097d1 Compare January 26, 2020 19:13

afbjorklund mentioned this pull request Jan 26, 2020

Automatically fork/exec to "podman-remote" if PODMAN_VARLINK_ADDRESS is set / implement podman -H #4390

Closed

openshift-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2020

TomSweeneyRedHat reviewed Jan 27, 2020

View reviewed changes

github-actions bot added the stale-pr label Mar 14, 2020

afbjorklund closed this May 4, 2020

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatically execute podman-remote if vars set #4981

Automatically execute podman-remote if vars set #4981

afbjorklund commented Jan 26, 2020

openshift-ci-robot commented Jan 26, 2020

openshift-ci-robot commented Jan 26, 2020

afbjorklund commented Jan 26, 2020

afbjorklund commented Jan 26, 2020

TomSweeneyRedHat commented Jan 27, 2020

TomSweeneyRedHat Jan 27, 2020

afbjorklund Jan 27, 2020

afbjorklund Feb 10, 2020

afbjorklund Feb 10, 2020

vrothberg commented Feb 12, 2020

afbjorklund commented Feb 12, 2020 •

edited

Loading

afbjorklund commented Feb 12, 2020 •

edited

Loading

github-actions bot commented Mar 14, 2020

rhatdan commented Mar 16, 2020

afbjorklund commented Mar 16, 2020 •

edited

Loading

vrothberg commented May 4, 2020

afbjorklund commented May 4, 2020

afbjorklund commented May 4, 2020

Automatically execute podman-remote if vars set #4981

Automatically execute podman-remote if vars set #4981

Conversation

afbjorklund commented Jan 26, 2020

openshift-ci-robot commented Jan 26, 2020

openshift-ci-robot commented Jan 26, 2020

afbjorklund commented Jan 26, 2020

afbjorklund commented Jan 26, 2020

TomSweeneyRedHat commented Jan 27, 2020

TomSweeneyRedHat Jan 27, 2020

Choose a reason for hiding this comment

afbjorklund Jan 27, 2020

Choose a reason for hiding this comment

afbjorklund Feb 10, 2020

Choose a reason for hiding this comment

afbjorklund Feb 10, 2020

Choose a reason for hiding this comment

vrothberg commented Feb 12, 2020

afbjorklund commented Feb 12, 2020 • edited Loading

afbjorklund commented Feb 12, 2020 • edited Loading

github-actions bot commented Mar 14, 2020

rhatdan commented Mar 16, 2020

afbjorklund commented Mar 16, 2020 • edited Loading

vrothberg commented May 4, 2020

afbjorklund commented May 4, 2020

afbjorklund commented May 4, 2020

afbjorklund commented Feb 12, 2020 •

edited

Loading

afbjorklund commented Feb 12, 2020 •

edited

Loading

afbjorklund commented Mar 16, 2020 •

edited

Loading