-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIv2 review corrections #3 #4965
APIv2 review corrections #3 #4965
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// parameters: | ||
// - name: "all" | ||
// in: "query" | ||
// description: "Show all images. Only images from a final layer (no children) are shown by default." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just say "non-dangling images" instead? It seems much clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats what you agreed to earlier ...
3fd43cd
to
afec62c
Compare
runtime := r.Context().Value("runtime").(*libpod.Runtime) | ||
|
||
query := struct { | ||
Changes map[string]string `json:"changes"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These json schemes should be schema.
afec62c
to
10f9b41
Compare
The third pass of corrections for the APIv2. Signed-off-by: Brent Baude <[email protected]>
10f9b41
to
5da70b0
Compare
review comments addressed, please merge |
/lgtm |
The third pass of corrections for the APIv2.
Signed-off-by: Brent Baude [email protected]