Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv2 review corrections #3 #4965

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

baude
Copy link
Member

@baude baude commented Jan 24, 2020

The third pass of corrections for the APIv2.

Signed-off-by: Brent Baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Jan 24, 2020
libpod/runtime_pod.go Outdated Show resolved Hide resolved
// parameters:
// - name: "all"
// in: "query"
// description: "Show all images. Only images from a final layer (no children) are shown by default."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just say "non-dangling images" instead? It seems much clearer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats what you agreed to earlier ...

@baude baude force-pushed the reviewcorrections3 branch 3 times, most recently from 3fd43cd to afec62c Compare January 24, 2020 15:51
pkg/api/handlers/generic/images.go Show resolved Hide resolved
pkg/api/handlers/libpod/images.go Show resolved Hide resolved
runtime := r.Context().Value("runtime").(*libpod.Runtime)

query := struct {
Changes map[string]string `json:"changes"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These json schemes should be schema.

pkg/api/handlers/libpod/pods.go Outdated Show resolved Hide resolved
pkg/api/handlers/types.go Outdated Show resolved Hide resolved
pkg/api/server/register_images.go Outdated Show resolved Hide resolved
The third pass of corrections for the APIv2.

Signed-off-by: Brent Baude <[email protected]>
@baude baude force-pushed the reviewcorrections3 branch from 10f9b41 to 5da70b0 Compare January 25, 2020 21:09
@baude
Copy link
Member Author

baude commented Jan 25, 2020

review comments addressed, please merge

@rhatdan
Copy link
Member

rhatdan commented Jan 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit d07f611 into containers:master Jan 26, 2020
@baude baude deleted the reviewcorrections3 branch May 18, 2022 15:22
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants