Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podman-remote info to show registry data #4802

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix podman-remote info to show registry data #4802

merged 1 commit into from
Jan 9, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 6, 2020

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Jan 6, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Jan 6, 2020

Fixes: #4793

@rhatdan
Copy link
Member Author

rhatdan commented Jan 6, 2020

@marusak PTAL
@baude @jwhonce @mheon @vrothberg @TomSweeneyRedHat PTAL

NevilleC
NevilleC reviewed Jan 6, 2020
View reviewed changes
API.md Outdated
@@ -1857,6 +1859,14 @@ graph_root [string](https://godoc.org/builtin#string)
graph_status [InfoGraphStatus](#InfoGraphStatus)

run_root [string](https://godoc.org/builtin#string)
### <a name="InfoRegistry"></a>type InfoRegistry

InfoRegistry describes the host's registry informatoin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/informatoin/information

@rhatdan rhatdan force-pushed the varlink branch 2 times, most recently from f22e779 to 3d0520a Compare January 6, 2020 22:08
@baude
Copy link
Member

baude commented Jan 6, 2020

code lgtm

vrothberg
vrothberg reviewed Jan 7, 2020
View reviewed changes
pkg/varlinkapi/system.go Outdated Show resolved Hide resolved
cmd/podman/varlink/io.podman.varlink Outdated Show resolved Hide resolved
pkg/varlinkapi/system.go Show resolved Hide resolved
pkg/varlinkapi/system.go Show resolved Hide resolved
mheon
mheon reviewed Jan 7, 2020
View reviewed changes
test/e2e/info_test.go Outdated
@@ -1,4 +1,4 @@
// +build !remoteclient
// +build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this entirely if it now allows the remote client?

@mheon
Copy link
Member

mheon commented Jan 7, 2020

Technically speaking this is a breaking API change, but we've never really managed those before for varlink...

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Jan 8, 2020

@mheon @baude Can we get this merged now?

vrothberg
vrothberg reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg reviewed Jan 9, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit f3fc10f into containers:master Jan 9, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NevilleC NevilleC NevilleC left review comments

@vrothberg vrothberg vrothberg left review comments

@mheon mheon mheon left review comments

@baude baude Awaiting requested review from baude

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhatdan @openshift-ci-robot @baude @mheon @vrothberg @NevilleC @openshift-merge-robot