Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: validate installed rpms #4795

Merged
merged 1 commit into from
Jan 8, 2020
Merged

packaging: validate installed rpms #4795

merged 1 commit into from
Jan 8, 2020

Conversation

ssbarnea
Copy link
Collaborator

@ssbarnea ssbarnea commented Jan 6, 2020 •
edited
Loading

Previously we builded RPMs that contained an outdated conmon which was not compatible. From now on make-install will also call podman version and podman info in order to perform a minimal sanity check of the installation.

Fixes: #4665

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2020
@ssbarnea ssbarnea self-assigned this Jan 6, 2020
@ssbarnea ssbarnea added ok-to-test and removed size/S labels Jan 6, 2020
@rhatdan
Copy link
Member

rhatdan commented Jan 6, 2020

@ssbarnea you need to sign your commits.
Fixes LGTM, but shouldn't we just be installing conmon package at this point? Rather then building it in the spec.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #4762) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 6, 2020
@ssbarnea ssbarnea changed the title Bump conmon version to 2.0.7 packaging: validate installed rpms Jan 7, 2020
@ssbarnea ssbarnea marked this pull request as ready for review January 7, 2020 14:08
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2020
@ssbarnea ssbarnea requested review from NevilleC and baude January 7, 2020 14:12
@ssbarnea ssbarnea added the Packaging Bug is in a Podman package label Jan 7, 2020
NevilleC
NevilleC reviewed Jan 7, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
edsantiago
edsantiago reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to see the .repo portion removed from this PR (it belongs in #4796) but will not block because of it.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
contrib/build_rpm.sh Outdated Show resolved Hide resolved
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Jan 7, 2020
@ssbarnea
Adds podman-package-centos-7 job
1a7d153 
As reviewer pointed on below comment, we may need to test with an
older system to validate rpm building.

Change-Id: Ie1b16db032e79eeb7ba9a674455ffa9023bae63d
Needed-By: containers/podman#4795
@ssbarnea
Copy link
Collaborator Author

ssbarnea commented Jan 7, 2020

Note to reviewers: is ok to see github-check that failed as it failed after successfully running the make package-install. That broken code is in rdo job definition and I am going to remove it from there.

edsantiago
edsantiago reviewed Jan 7, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
contrib/build_rpm.sh Show resolved Hide resolved
@ssbarnea
packaging: validate installed rpms
da0319f 
Previously we builded RPMs that contained an outdated conmon which was
not compatible. From now on `make-install` will also call
`podman version` and `podman info` in order to perform a minimal
sanity check of the installation.

Fixes: #4665
Signed-off-by: Sorin Sbarnea <[email protected]>
@containers containers deleted a comment from openshift-ci-robot Jan 7, 2020
@ssbarnea ssbarnea requested a review from edsantiago January 7, 2020 20:35
@baude
Copy link
Member

baude commented Jan 7, 2020

lgtm if we can get the last test to pass

@rhatdan
Copy link
Member

rhatdan commented Jan 7, 2020

/approve
/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2020
NevilleC
NevilleC approved these changes Jan 7, 2020
View reviewed changes
Copy link
Collaborator

@NevilleC NevilleC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NevilleC, rhatdan, ssbarnea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ssbarnea
Copy link
Collaborator Author

ssbarnea commented Jan 8, 2020

Fixes LGTM, but shouldn't we just be installing conmon package at this point? Rather then building it in the spec.

If we are to switch to external conmon we need extra testing and it would outside the scope if this change. Not against but we need to assert availability on all rpm supported platforms (4 atm).

@rhatdan
Copy link
Member

rhatdan commented Jan 8, 2020

/hold cancel
Lets move to external conmon in separate PR.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2020
@rhatdan
Copy link
Member

rhatdan commented Jan 8, 2020

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit a8a7668 into containers:master Jan 8, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago left review comments

@NevilleC NevilleC NevilleC approved these changes

@mheon mheon Awaiting requested review from mheon

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@baude baude Awaiting requested review from baude

Assignees

@ssbarnea ssbarnea

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. ok-to-test Packaging Bug is in a Podman package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: could not get runtime: please update to v2.0.1 or later: outdated conmon version (CentOS 8)
8 participants
@ssbarnea @rhatdan @rh-atomic-bot @baude @openshift-ci-robot @edsantiago @NevilleC @openshift-merge-robot