refactor network commands

[baude]

move core of network commands from pkg/adapter to pkg/network to assist
with api development and remote podman commands.

Signed-off-by: baude [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

this is blocking apiv2 work. please review and merge

[mheon]

Can we return anything better than this? I know that CNI doesn't bother exporting most types, but can we potentially provide some sort of struct defining what contents could be?

[baude]

It is really too loosely defined to do much more. I don't like it either.

[mheon]

@baude I mean, it is Sunday of shutdown 😄

[mheon]

Ack. LGTM then.

…

On Mon, Dec 30, 2019, 12:23 Brent Baude ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkg/network/network.go <#4757 (comment)>: > + return errors.Wrapf(err, "failed to get live network names") + } + if util.StringInSlice(interfaceName, liveNetworkNames) { + if err := RemoveInterface(interfaceName); err != nil { + return errors.Wrapf(err, "failed to delete the network interface %q", interfaceName) + } + } + // Remove the configuration file + if err := os.Remove(cniPath); err != nil { + return errors.Wrapf(err, "failed to remove network configuration file %q", cniPath) + } + return nil +} + +// InspectNetwork reads a CNI config and returns its configuration +func InspectNetwork(name string) (map[string]interface{}, error) { It is really too loosely defined to do much more. I don't like it either. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#4757>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3AOCB7OOEB2N5WS4OHV2TQ3IU77ANCNFSM4KARK66Q> .

[rhatdan]

/lgtm